Conversation
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
go/go.mod
Outdated
| module github.com/cncf/xds/go | ||
|
|
||
| go 1.11 | ||
| go 1.20 |
There was a problem hiding this comment.
can bump to go 1.21
BTW, add a go mod verify
There was a problem hiding this comment.
I think I was wrong to bump it that high in the first place. This is the minimal version of go required to use this module: https://go.dev/ref/mod#go-mod-file-go
So projects like grpc won't be able to use this package because they declare lower minimal version, f.e. 1.19 in gRPC's case: https://github.com/grpc/grpc-go/blob/287c47355e154ac2193bf743c886656cd48e753c/go.mod#L3
I think we should set it to something reasonable, higher than 1.11, but lower than 1.20.
There was a problem hiding this comment.
Should this be set to the version of grpc (1.19) then?
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
|
This is ready for review now. |
|
Just FYI - since this changes the minimal required version of the go module, we shouldn't merge it during the Thanksgiving week 😄 |
Good idea :) |
|
@adisuissa Good to go now. |
…ncf#79)" This reverts commit 5b9bca5. Reverts cncf#79. Now that cncf#78 `go build` CI is in place; this PR brings back the CEL fields. Once `del.dev` domain is fixed, we'll see the CI passing and will be able to merge this PR. Original comment --- This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. --- Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
…ncf#79)" This reverts commit 5b9bca5. Reverts cncf#79. Now that cncf#78 `go build` CI is in place; this PR brings back the CEL fields. Once `del.dev` domain is fixed, we'll see the CI passing and will be able to merge this PR. Original comment Signed-off-by: Sergii Tkachenko <sergiitk@google.com> --- This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. --- Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
3 participants
One of the recent PRs broke go users: #76. This PR is to address this type of error by adding
cd go && go build ./...step to the CI.Major changes:
github.com/cncf/xds/gois now set to1.19(same asgoogle-cloud-go,aws-sdk-go,grpc-go).Fixes #77.
Closes #67, #18.